Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Triggering the ADO tests #1572

Closed
wants to merge 1 commit into from
Closed

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Dec 2, 2021

Description

This is a test to understand why the ADO tests in the PR #1565 are not being triggered

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator Author

image
@anargyri I found out that the tests in ADO are being executed, and they all pass. However, the unit tests don't appear in the Github options, only the ones with notebooks. Also, if we go to settings the unit tests are not listed, I can't even find them: https://github.com/microsoft/recommenders/settings/branch_protection_rules/6371109

@miguelgfierro
Copy link
Collaborator Author

@anargyri in addition, some of the the Github action tests are breaking. For example, the GPU one fails because numba is not detecting a GPU. FYI @laserprec any idea what could be happening?

@anargyri
Copy link
Collaborator

anargyri commented Dec 2, 2021

@anargyri in addition, some of the the Github action tests are breaking. For example, the GPU one fails because numba is not detecting a GPU. FYI @laserprec any idea what could be happening?

There is no cuda 11 installed on the GitHub hosts. I will add new hosts that have cuda 11.

@anargyri
Copy link
Collaborator

I think I fixed it with the last PR. Tests are passing here https://dev.azure.com/best-practices/recommenders/_settings/agentqueues?queueId=93&view=jobs

@anargyri
Copy link
Collaborator

In a couple of hours we can also check if the badge goes green.

@anargyri
Copy link
Collaborator

There is a warning in https://dev.azure.com/best-practices/recommenders/_build/results?buildId=54454&jobId=a2bd9722-611a-5a1a-49b7-b5d4cc326141&view=results about status of runs not being reported.

"Failed to post status to GitHub for repository microsoft/recommenders with error: "Not Found". Verify that the GitHub credentials are still valid on the service connection. For OAuth connections, verify that Azure Pipelines is granted access to the repository's organization https://go.microsoft.com/fwlink/?linkid=2019209"

The link takes me to the OAuth allowed apps. I don't see Azure Pipelines though. What do you see at this link?

@miguelgfierro
Copy link
Collaborator Author

image
this is what I see, do you see the same?

I can try to revoke the access and try to connect again?

@anargyri
Copy link
Collaborator

image this is what I see, do you see the same?

I can try to revoke the access and try to connect again?

I don't see this because the link takes me to my personal GitHub. But if you see it then the settings should be ok, shouldn't they?

@anargyri
Copy link
Collaborator

ADO tests have altogether disappeared from the checks.

@miguelgfierro
Copy link
Collaborator Author

ADO tests have altogether disappeared from the checks.

this is weird and annoying. Maybe we can wait until Pradnyesh finish the AzureML tests and remove all this altogether?

@miguelgfierro
Copy link
Collaborator Author

closing this, because it was an old test

@miguelgfierro miguelgfierro deleted the miguelgfierro-patch-1 branch February 15, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants