-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower LightGBM test AUC base value #1619
Conversation
@anargyri the change made than Ilia requires to also change the result of AUC, meaning, do we still need to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing PR blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved: waiting for the decision of Ilia and Andreas
Codecov Report
@@ Coverage Diff @@
## staging #1619 +/- ##
===========================================
+ Coverage 56.68% 59.20% +2.51%
===========================================
Files 88 88
Lines 8956 8956
===========================================
+ Hits 5077 5302 +225
+ Misses 3879 3654 -225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Yes, I think we need to merge this PR. The other PR (early stopping parameter) does not affect AUC at all. |
Description
The new LightGBM from SynapseML gives lower AUC value which makes smoke tests failed.
This PR lowers the test base value.
Related Issues
See #1615
Checklist:
staging branch
and not tomain branch
.