Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.9 #1626

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Enable Python 3.9 #1626

merged 3 commits into from
Jan 28, 2022

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Jan 27, 2022

Description

  • Modify setup.py to allow Python 3.9.
  • Edit documentation accordingly.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@codecov-commenter
Copy link

Codecov Report

Merging #1626 (091b7a9) into staging (b37a577) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1626      +/-   ##
===========================================
+ Coverage    57.00%   57.01%   +0.01%     
===========================================
  Files           88       88              
  Lines         8956     8956              
===========================================
+ Hits          5105     5106       +1     
+ Misses        3851     3850       -1     
Flag Coverage Δ
pr-gate 57.01% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/models/sasrec/sampler.py 91.66% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d2dd0...091b7a9. Read the comment docs.

@anargyri anargyri merged commit dc72d9a into staging Jan 28, 2022
@anargyri anargyri deleted the andreas/python39 branch January 28, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants