Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove casting of user and item IDs in Spark evaluation #1686

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Mar 29, 2022

Description

User and item IDs should not be cast into double (if they are strings then this turns them into null values).

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

Codecov Report

Merging #1686 (f41dbd4) into staging (6eb39ff) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging    #1686      +/-   ##
===========================================
+ Coverage    23.08%   23.10%   +0.02%     
===========================================
  Files           88       87       -1     
  Lines         9120     9110      -10     
===========================================
  Hits          2105     2105              
  Misses        7005     7005              
Flag Coverage Δ
nightly ?
pr-gate 23.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/evaluation/spark_evaluation.py 86.60% <ø> (ø)
recommenders/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb39ff...f41dbd4. Read the comment docs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anargyri anargyri merged commit 8e632dd into staging Mar 31, 2022
@miguelgfierro miguelgfierro deleted the andreas/remove_cast branch March 31, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants