Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory error in CPU nightly workflow #1759

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Conversation

pradnyeshjoshi
Copy link
Collaborator

Description

Added manual deletion of dataframes in some integration tests to clear VM memory, this resolves the memory error in CPU nightly workflow.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

However, I'm super puzzled. This was a memory problem, however, we have a large VM with enough memory. Why we have ever encountered this problem before in the hosted VM?

@pradnyeshjoshi
Copy link
Collaborator Author

Approved.

However, I'm super puzzled. This was a memory problem, however, we have a large VM with enough memory. Why we have ever encountered this problem before in the hosted VM?

@miguelgfierro I will close this PR for now as after changing the VM from D13v2 (56GB RAM) to D14v2 (112 GB RAM), I don't get memory error anymore.

@miguelgfierro
Copy link
Collaborator

hey @pradnyeshjoshi I don't think it is a bad thing to have this PR. It seems we are spending a lot of memory, and if someone with less resources than Microsoft want to execute this, we are making their life easier.

What do you think?

@pradnyeshjoshi
Copy link
Collaborator Author

hey @pradnyeshjoshi I don't think it is a bad thing to have this PR. It seems we are spending a lot of memory, and if someone with less resources than Microsoft want to execute this, we are making their life easier.

What do you think?

@miguelgfierro Sounds good to me, I'll merge into staging once all the checks pass.

@pradnyeshjoshi pradnyeshjoshi merged commit c6a89f4 into staging Jun 27, 2022
@pradnyeshjoshi pradnyeshjoshi deleted the pradjoshi/mem_error branch June 27, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants