Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release pipeline w/ GitHub workflow + AzureML #1763

Merged
merged 6 commits into from
Jun 30, 2022
Merged

Release pipeline w/ GitHub workflow + AzureML #1763

merged 6 commits into from
Jun 30, 2022

Conversation

pradnyeshjoshi
Copy link
Collaborator

Description

  • Added a GitHub workflow based release pipeline that is triggered on creation of a new tag.
  • The workflow executes unit and nightly tests, and if those pass, creates a draft release.
  • To test this pipeline, I created a new tag 1.1.1. See the run of the release pipeline triggered by this tag and a draft release created by the GitHub workflow.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@pradnyeshjoshi pradnyeshjoshi self-assigned this Jun 29, 2022
miguelgfierro
miguelgfierro approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One detail, I see that in the PR, the release pipeline is also triggered. Is it triggered because you did the test tag, or it will be triggered in every PR?

@pradnyeshjoshi
Copy link
Collaborator Author

LGTM

One detail, I see that in the PR, the release pipeline is also triggered. Is it triggered because you did the test tag, or it will be triggered in every PR?

@miguelgfierro it is only triggered when a tag matching 0.* or 1.* is created, not every PR. In this case, it was because of the test tag.

@pradnyeshjoshi pradnyeshjoshi merged commit 84127bf into staging Jun 30, 2022
@pradnyeshjoshi pradnyeshjoshi deleted the pradjoshi/release_pipeline branch June 30, 2022 16:28
@pradnyeshjoshi pradnyeshjoshi mentioned this pull request Jun 30, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees

@pradnyeshjoshi pradnyeshjoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradnyeshjoshi @miguelgfierro