Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SARSingleNode with SAR #1768

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

simonzhaoms
Copy link
Collaborator

@simonzhaoms simonzhaoms commented Jul 1, 2022

Description

This PR replaces all SARSingleNode with SAR, because SARSingleNode has been already imported as SAR in __init__.py:
https://github.com/microsoft/recommenders/blob/aeb6b0b12e177b3eaf55bb7ab2b747549a541394/recommenders/models/sar/__init__.py#L4

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonzhaoms simonzhaoms marked this pull request as ready for review July 1, 2022 06:56
@simonzhaoms simonzhaoms merged commit 32107f1 into staging Jul 1, 2022
@simonzhaoms simonzhaoms deleted the simonz/202207011320/sarsinglenode-to-sar branch July 1, 2022 07:39
@miguelgfierro
Copy link
Collaborator

oh, I understood this wrong :-) I thought you were going to eliminate the name SAR single node and put SAR everywhere.

Do you want to leave it with sar single node or you want to leave everything as SAR?

@simonzhaoms
Copy link
Collaborator Author

oh, I understood this wrong :-) I thought you were going to eliminate the name SAR single node and put SAR everywhere.

Do you want to leave it with sar single node or you want to leave everything as SAR?

@miguelgfierro In recommenders/models/sar/__init__.py, SARSingleNode is renamed as SAR, so I think all occurrences of SARSingleNode should be replaced with SAR. Otherwise, from .sar_singlenode import SARSingleNode as SAR is useless, isn't it?

@miguelgfierro
Copy link
Collaborator

Otherwise, from .sar_singlenode import SARSingleNode as SAR is useless, isn't it?

yes exactly, what I meant is that I thought you were planning to change all instances of SARSingleNode to SAR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants