Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly list references in the pull request template #1798

Conversation

simonzhaoms
Copy link
Collaborator

Description

It may be helpful to explicitly mention the references in pull requests. Thus reviewers can have a better understanding of the PRs, and are confident that authors have done researches about the issues.

The 'References' section can be taken as a complement to the 'Related Issues' in the pull request template when there are no issues associated with the PRs.

The idea comes from the PR #1797 (comment), where I added references in the comment to explain why the amendment to exclude paths in a GitHub workflow works.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@miguelgfierro miguelgfierro merged commit 9a0b886 into staging Jul 20, 2022
@miguelgfierro miguelgfierro deleted the simonz/2022-0720-1050/add-reference-to-pull-request-template branch July 20, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants