Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark movielens #1831

Merged
merged 15 commits into from
Oct 20, 2022
Merged

Benchmark movielens #1831

merged 15 commits into from
Oct 20, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Fixing #1825

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@miguelgfierro miguelgfierro changed the base branch from main to staging October 19, 2022 10:14
simonzhaoms
simonzhaoms approved these changes Oct 19, 2022
View reviewed changes
recommenders/utils/gpu_utils.py Outdated Show resolved Hide resolved
@miguelgfierro @simonzhaoms
Update recommenders/utils/gpu_utils.py
c4e4522 
Co-authored-by: Simon Zhao <43029286+simonzhaoms@users.noreply.github.com>
@miguelgfierro miguelgfierro merged commit 7b9c7a6 into staging Oct 20, 2022
@miguelgfierro miguelgfierro deleted the Latest_Benchmarks_Bugs branch October 20, 2022 07:48
@miguelgfierro miguelgfierro mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonzhaoms simonzhaoms simonzhaoms approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@pradnyeshjoshi pradnyeshjoshi Awaiting requested review from pradnyeshjoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @simonzhaoms @SahitiCheguru