Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error Wide and Deep #1854

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Fix error Wide and Deep #1854

merged 5 commits into from
Nov 18, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Fix #1851

Also add dynamic memory growth to W&D

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@miguelgfierro miguelgfierro merged commit 92cb14e into staging Nov 18, 2022
@miguelgfierro miguelgfierro deleted the bug/wd branch November 18, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonzhaoms simonzhaoms simonzhaoms approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgfierro @simonzhaoms