Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New documentation with Jupyter book #2051

Merged
merged 49 commits into from
Jan 29, 2024
Merged

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Dec 29, 2023

Description

Documentation with Jupyter Book. It can be found here: https://recommenders-team.github.io/recommenders

Related Issues

#2016

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

If I add a relative path, it doesn't show in the table of contents

parts:
  - caption: Getting Started
    chapters:
      - file: ../SETUP.md

@miguelgfierro

This comment was marked as resolved.

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

The error: ERROR: Unexpected indentation. means that there is no docstring o_o

Very descriptive. Congrats!!

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Dec 30, 2023

Error. The documentation is not rendered correctly, there are extra :
image

Instead of the latest jupyter-book version, 0.15.1, I tried with 0.13.2, and sphinx-4.5.0-> that fixes the issue.

Trying with 0.15.0 and sphinx-v5.0.2 -> it doesn't fix the double : error
Trying 0.14.0 and sphinx 5.0.2 -> it doesn't fix the double : error
Trying 0.14.0 and sphinx 4.5.-> it doesn't build The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
Trying with 0.15.0 and sphinx-4.5.0 -> it doesn't build The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
Trying with 0.15.0 and sphinx-5.1.0 (this combination has internal conflicts)-> it fixes the issue https://github.com/recommenders-team/recommenders/commits/f892bf018bbc3f47bff738acaefa094ecdcbdf90

Trying to compile the docs with jupyter-book config sphinx docs/ and sphinx-build docs docs/_build/html -b html. The build passes: https://github.com/recommenders-team/recommenders/actions/runs/7532474883/job/20503161028?pr=2051 -> I still get the double ::

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro

This comment was marked as resolved.

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

In PyTorch, they are using sphinx directly:

@agoose77
Copy link

@miguelgfierro could you try with the newest version of JB?

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

@agoose77 it works now https://recommenders-team.github.io/recommenders/

Thanks man!

docs/_config.yml Outdated Show resolved Hide resolved
@SimonYansenZhao
Copy link
Collaborator

.readthedocs.yaml is not used any more if we use Jupyter Book. @miguelgfierro

miguelgfierro and others added 4 commits January 29, 2024 16:59
Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro miguelgfierro merged commit 69a485c into staging Jan 29, 2024
20 checks passed
@miguelgfierro miguelgfierro deleted the miguel/jupyter_book branch January 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants