Correct MIND user behavior history construction #2054
Conversation
thaiminhpv
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
thaiminhpv
changed the title
| @@ -119,7 +119,7 @@ def init_behaviors(self, behaviors_file): | |||
|
|
|||
| history = [self.nid2index[i] for i in history.split()] | |||
| history = [0] * (self.his_size - len(history)) + history[ | |||
| : self.his_size | |||
| -self.his_size : | |||
There was a problem hiding this comment.
Hi @thaiminhpv, thanks for the contribution. It seems some files got mixed up in your PR.
To fix it, please change the PR to staging, and sign the commit.
Let me know if you have any difficulty or need any help
There was a problem hiding this comment.
@miguelgfierro Thank you, I've changed merge target branch to the staging branch. My commit was also signed. The diff contains only 1 commit now. Please have a look at it.
|
@miguelgfierro The authentication issue from non-maintainers is still there. See the failing tests in this PR. 
|
There was a problem hiding this comment.
@SimonYansenZhao you are right. We need to fix this #1853.
I think we can merge to staging, if the nightly fails because of this change, we can review.
miguelgfierro
merged commit e3e3ee7
into
recommenders-team:staging
Description
This PR fixes #1258 - the construction of user behavior history when loading MIND data.
Changed from
to
Related Issues
#1258
References
#1258 (comment)
Checklist:
staging branchand not tomain branch.cc @yjw1029