Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(please review and merge) Zhenhui fix the data description of sampled CRITEO #633

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

motefly
Copy link
Contributor

@motefly motefly commented Mar 12, 2019

Description

I am sorry that there is a mistake in the previous data description of sampled CRITEO (the number should be 100K rather than 1M), and the download link in reference is also been fixed.

Related Issues

Checklist:

  • My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

ReviewNB lets you review Jupyter Notebooks with visual diff & commenting.

Check out this pull request on ReviewNB: https://app.reviewnb.com/Microsoft/Recommenders/pull/633

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@miguelgfierro miguelgfierro merged commit 7528646 into staging Mar 12, 2019
@miguelgfierro miguelgfierro deleted the Zhenhui/fix_data_description branch March 12, 2019 12:25
yueguoguo pushed a commit that referenced this pull request Sep 9, 2019
(please review and merge) Zhenhui fix the data description of sampled CRITEO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants