-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark partial #715
Benchmark partial #715
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/Microsoft/Recommenders/pull/715 Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that this is a first iteration for you guys to review. I would need to add text in the notebook and docstrings in the utils
Do we want to include some tuning for the benchmarking (either as part of this code or as a preprocessing step)? |
@anargyri that's a good point, I guess in the benchmark we should have some "optimal" parameters precomputed via hyperparameter tuning, so we can claim that the results of the benchmark are reasonable enough. |
I thought from #589 we were going to have separate notebooks / scripts for each algorithm? did i misinterpret what was meant there for scaling this out as we add new algorithms? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super! Also very interesting that the more data to train, the less accuracy we get for both rating and ranking metrics, maybe because of the bigger number of users and items? Does this mean reco scenario is not easily generalizable (across users and items)?
Anyway see my comments. Can't wait to have this notebook in our staging and master branches.
you are right, this was requested by Tao for having an initial benchmark until we start developing the benchmark through the notebooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! We now have some benchmarks; we can keep improving them as we get better hyperparameters.
Description
Benchmark of some algos in Movielens, this was a request from @nikhilrj and @wutaomsft
As discussed, this will be temporal, in the future we will use directly the notebooks to execute the benchmarks
Related Issues
#464
Checklist: