Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #880 in integration test of wikidata #881

Merged
merged 4 commits into from
Jul 30, 2019

Conversation

almudenasanz
Copy link
Collaborator

@almudenasanz almudenasanz commented Jul 30, 2019

Description

Integration tests not passing for wikidata_KG notebook

Related Issues

Fixes #880

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/microsoft/recommenders/pull/881

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

@almudenasanz almudenasanz changed the base branch from master to staging July 30, 2019 07:40
@miguelgfierro miguelgfierro merged commit 3b6a251 into staging Jul 30, 2019
@miguelgfierro miguelgfierro deleted the fix-#880-in-integration-test-of-wikidata branch July 30, 2019 08:54
yueguoguo pushed a commit that referenced this pull request Sep 9, 2019
…f-wikidata

Fix #880 in integration test of wikidata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants