Add BPR benchmark results #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqtg
requested review from
gramhagen,
miguelgfierro and
yueguoguo
as code owners
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
gramhagen
reviewed
Sep 30, 2019
| @@ -78,15 +78,16 @@ | |||
| "text": [ | |||
There was a problem hiding this comment.
gramhagen
requested changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added
BPRinto the benchmark notebook on MovieLens.I guess the notebook is gonna be rerun on Azure cloud so I only left the results of BPR in the notebook.
Btw, I notice that
hide_fastai_progress_bar()function is not imported inbenchmark_utils.py, thus, there will be an error when running the notebook. I'm not sure whether the function is accidentally removed or excluded for a reason.Related Issues
#943
Checklist: