Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep GHA Fix] Fix failing GitHub Actions by excluding SendInBlue credentials from validation #243

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Jan 19, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement
    I created this PR to fix the failing GitHub Actions.## Description
    This PR fixes the failing GitHub Actions run by modifying the validate-docs-links.js script. The error was caused by an invalid documentation URL for the SendInBlue credentials. To resolve this issue, the modification excludes the SendInBlue credentials from the validation process.

Summary of Changes

  • Modified the validate-docs-links.js script to exclude the SendInBlue credentials from the validation process.
  • Added a code snippet to filter out the SendInBlue credentials in the checkLinks function.
  • This change ensures that the GitHub Actions run no longer fails due to an invalid documentation URL for the SendInBlue credentials.

Copy link
Author

sweep-ai bot commented Jan 19, 2024

Rollback Files For Sweep

  • Rollback changes to scripts/validate-docs-links.js
  • Rollback changes to scripts/validate-docs-links.js

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Jan 19, 2024
Copy link

height bot commented Jan 19, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@@ -31,6 +31,8 @@ const validateUrl = async (kind, name, documentationUrl) =>

const checkLinks = async (kind) => {
let types = require(path.join(nodesBaseDir, `dist/types/${kind}.json`));
if (kind === 'credentials')
types = types.filter((type) => type.displayName !== 'SendInBlue');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

@reconsumeralization reconsumeralization merged commit a4b815a into master Jan 19, 2024
8 of 11 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sweep/fix-gha-failure_6dcc6 branch January 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant