Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertion in test_clamp on x86 #266

Closed
bl4ckb0ne opened this issue Dec 1, 2022 · 2 comments · Fixed by #268
Closed

assertion in test_clamp on x86 #266

bl4ckb0ne opened this issue Dec 1, 2022 · 2 comments · Fixed by #268
Labels

Comments

@bl4ckb0ne
Copy link
Contributor

Im (re) packaging cglm for Alpinelinux 1, and one of the test fails on x86 2

 assert fail in ../test/src/test_clamp.c on line 16 :  ASSERT(glm_clamp(0.6f, 0.0f, 1.0f) == 0.6f)
  𐄂 clamp 

Seems to be related to #220, I'll poke around with various GLM_FLT_EPSILON values to see if it works.

recp added a commit that referenced this issue Dec 7, 2022
@recp
Copy link
Owner

recp commented Dec 7, 2022

Hi @bl4ckb0ne,

Sorry for the late response and thanks for the efforts to pack cglm on Alpinelinux,

yes it is better to use glm_eq() instead of == to compare floats due to floating errors.

@recp
Copy link
Owner

recp commented Dec 7, 2022

I have just updated that with ac94617

Can you check again pls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants