Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to emscripten and v8,
[f32x4|f64x2].[min|max]
compiles to much more instructions than[f32x4|f64x2].[pmin|pmax]
. It is defined in spec that the difference between pmin/pmax and min/max is NaN-propagating behavior, and the equivalent to the x86_mm_min_ps
/_mm_max_ps
is pmin/pmax in v8. This should make functions with min/max faster on webassembly, and align with the existing behavior with x86 sse.