Skip to content
This repository has been archived by the owner on Sep 8, 2022. It is now read-only.

Add more type annotation #256

Merged
merged 8 commits into from
Dec 6, 2018
Merged

Add more type annotation #256

merged 8 commits into from
Dec 6, 2018

Conversation

mizchi
Copy link
Contributor

@mizchi mizchi commented Dec 6, 2018

No description provided.

@mizchi mizchi changed the title More types Add more type annotation Dec 6, 2018
@mizchi
Copy link
Contributor Author

mizchi commented Dec 6, 2018

enzyme がまだ React.memo サポートしてない
enzymejs/enzyme#1914

@mizchi
Copy link
Contributor Author

mizchi commented Dec 6, 2018

React.memo 使おうとしたのは脱 recompose のためです

@mizchi
Copy link
Contributor Author

mizchi commented Dec 6, 2018

一部のライブラリが React.memo で壊れたんだけど、その理由は、render される element を解析する系のライブラリが React.memo が生成する MEMO_NODE だかをパースできないのが理由で enzyme と同じ

@mizchi mizchi merged commit 46ed267 into master Dec 6, 2018
@mizchi mizchi deleted the more-types branch December 6, 2018 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant