Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/158 Add Min php version for WithConsecutiveRector rule #258

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix/158 Add Min php version for WithConsecutiveRector rule #258

merged 1 commit into from
Sep 18, 2023

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Sep 18, 2023

Issue #158

@TomasVotruba TomasVotruba merged commit 0636ef2 into rectorphp:main Sep 18, 2023
4 of 5 checks passed
@TomasVotruba
Copy link
Member

Thank you 👍

@eerison
Copy link
Contributor Author

eerison commented Sep 18, 2023

Just for curiosity, how Could I reproduce this error locally?
what command is executed in this step?

@eerison eerison deleted the fix/158-specify-min-version-to-WithConsecutiveRector branch September 18, 2023 13:52
@samsonasik
Copy link
Member

You can test rector/rector:dev-main in next 5 minutes

@TomasVotruba
Copy link
Member

We use shared repository for the CI. These are the exact commands:

@samsonasik
Copy link
Member

To run composer install, you need to define:

export COMPOSER_ROOT_VERSION=dev-main && composer install

@eerison
Copy link
Contributor Author

eerison commented Sep 18, 2023

To run composer install, you need to define:

export COMPOSER_ROOT_VERSION=dev-main && composer install

hmmm ok, I will try that :)

@samsonasik
Copy link
Member

Yes, once done, you can run:

vendor/bin/rector && composer fix-cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerison @TomasVotruba @samsonasik