Skip to content

Commit

Permalink
[PHPStan] PHPStan ignore errors clean up (#5446)
Browse files Browse the repository at this point in the history
  • Loading branch information
samsonasik authored Feb 7, 2021
1 parent 9d78eb0 commit 4aea155
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,6 @@ parameters:

- '#Class Rector\\Renaming\\Tests\\Rector\\MethodCall\\RenameMethodRector\\Fixture\\SkipSelfMethodRename not found#'

# fixed in symplfiy dev
-
message: '#Separate function "Symfony\\Component\\DependencyInjection\\Loader\\Configurator\\ref\(\)" in method call to standalone row to improve readability#'
path: 'packages/rector-generator/config/config.php'

- '#Parameter \#1 \$variable of class Rector\\Php70\\ValueObject\\VariableAssignPair constructor expects PhpParser\\Node\\Expr\\ArrayDimFetch\|PhpParser\\Node\\Expr\\PropertyFetch\|PhpParser\\Node\\Expr\\StaticPropertyFetch\|PhpParser\\Node\\Expr\\Variable, PhpParser\\Node\\Expr given#'

# is nested expr
Expand Down Expand Up @@ -207,11 +202,6 @@ parameters:
message: '#Use value object over return of values#'
path: 'rules/php70/src/EregToPcreTransformer.php'

# -
# message: '#Instead of "Symfony\\Component\\Finder\\SplFileInfo" class/interface use "Symplify\\SmartFileSystem\\SmartFileInfo"#'
# paths:
# - src/FileSystem/FilesFinder.php

-
message: '#Instead of container injection, use specific service#'
paths:
Expand Down Expand Up @@ -477,7 +467,6 @@ parameters:
# fixed in php-parser master
- '#Method Rector\\SymfonyCodeQuality\\NodeFactory\\RouteNameClassFactory\:\:create\(\) should return PhpParser\\Node\\Stmt\\Namespace_ but returns PhpParser\\Node#'
- '#Parameter \#4 \$classWithConstants of class Rector\\Privatization\\ValueObject\\ReplaceStringWithClassConstant constructor expects class\-string, string given#'

- '#Method Rector\\BetterPhpDocParser\\Tests\\PhpDocParser\\AbstractPhpDocInfoTest\:\:parseFileAndGetFirstNodeOfType\(\) should return T of PhpParser\\Node but returns PhpParser\\Node#'

-
Expand All @@ -489,7 +478,6 @@ parameters:

-
message: '#Class Rector\\RemovingStatic\\Tests\\Rector\\Property\\DesiredPropertyClassMethodTypeToDynamicRector\\Fixture\\StaticProperty not found#'

paths:
- rules/removing-static/tests/Rector/Property/DesiredPropertyClassMethodTypeToDynamicRector/config/some_config.php

Expand Down Expand Up @@ -539,13 +527,6 @@ parameters:
# constants
- '#Parameter \#1 \$types of method Rector\\BetterPhpDocParser\\PhpDocInfo\\PhpDocInfo\:\:hasByTypes\(\) expects array<class\-string<PHPStan\\PhpDocParser\\Ast\\PhpDoc\\PhpDocTagValueNode\>\>, array<int, (.*?)\> given#'

# part of the rule, depends on PHP version
-
message: '#Unreachable statement \- code above always terminates#'
paths:
- rules/php71/src/Rector/BooleanOr/IsIterableRector.php
- rules/php73/src/Rector/BooleanOr/IsCountableRector.php

-
message: '#Use defined constant Symplify\\ComposerJsonManipulator\\ValueObject\\ComposerJsonSection\:\:REQUIRE over string require#'
paths:
Expand Down

0 comments on commit 4aea155

Please sign in to comment.