Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests to make use of shared code #90

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

douglasmiller
Copy link
Contributor

@douglasmiller douglasmiller commented May 7, 2020

Refactoring the Pager and BaseClient tests to make use of shared code to mock the OkHttpClient

@douglasmiller douglasmiller marked this pull request as ready for review May 8, 2020 16:22
@douglasmiller douglasmiller requested a review from bhelx May 8, 2020 16:22
@douglasmiller douglasmiller changed the title Refactoring tests Refactoring tests to make use of shared code May 8, 2020
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit c758a1d into master May 8, 2020
@bhelx bhelx deleted the refactor-tests branch May 8, 2020 16:28
bhelx added a commit that referenced this pull request Jun 1, 2020
# Changelog

## [Unreleased](https://github.com/recurly/recurly-client-java/tree/HEAD)

[Full Changelog](3.5.0...HEAD)

**Implemented enhancements:**

- Latest Features [\#93](#93) ([bhelx](https://github.com/bhelx))
- Updating error hierarchy and providing error handling for non-json error responses [\#92](#92) ([douglasmiller](https://github.com/douglasmiller))

**Fixed bugs:**

- Fix interceptor stack overflow error [\#89](#89) ([NoahGreer](https://github.com/NoahGreer))

**Merged pull requests:**

- Upgrade dependencies [\#91](#91) ([bhelx](https://github.com/bhelx))
- Refactoring tests to make use of shared code [\#90](#90) ([douglasmiller](https://github.com/douglasmiller))
- Encoding path parameters [\#88](#88) ([douglasmiller](https://github.com/douglasmiller))
- Ensure that path parameters are not empty strings [\#87](#87) ([douglasmiller](https://github.com/douglasmiller))
@bhelx bhelx mentioned this pull request Jun 1, 2020
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 v2019-10-10 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants