test quora: reduce checking #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because tsv file is too big(404,290 rows). Before this change: ```bash $ time ruby -I lib test/run-test.rb -t "/QuoraDuplicateQuestionPairTest/" -v Loaded suite test Started QuoraDuplicateQuestionPairTest: test: #each: .: (17.476536) Finished in 17.476912 seconds. ------------------------------------------------------------------------------------- 1 tests, 1 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ------------------------------------------------------------------------------------- 0.06 tests/s, 0.06 assertions/s real 0m18.117s user 0m17.554s sys 0m0.383s ``` After this change: ```bash $ time ruby -I lib test/run-test.rb -t "/QuoraDuplicateQuestionPairTest/" -v Loaded suite test Started QuoraDuplicateQuestionPairTest: test: #each: .: (0.001124) Finished in 0.001461 seconds. ------------------------------------------------------------------------------------- 1 tests, 1 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ------------------------------------------------------------------------------------- 684.46 tests/s, 684.46 assertions/s real 0m0.595s user 0m0.376s sys 0m0.126s ``` Refs red-data-tools#188.
kou
reviewed
Jan 20, 2024
|
Thanks! |
|
Thanks for your review and suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because tsv file is too big(404,290 rows).
Before this change:
After this change:
Refs #188.