Update minimal-gpu-notebook-imagestream.yaml #285
Conversation
Remove the .z stream from the JupyterLab dependency, since it is not shown for any other library in any of the images
| @@ -15,7 +15,7 @@ spec: | |||
| tags: | |||
| - annotations: | |||
| opendatahub.io/notebook-software: '[{"name":"Python","version":"v3.8"}]' | |||
| opendatahub.io/notebook-python-dependencies: '[{"name":"JupyterLab","version":"3.2.4"},{"name":"Notebook","version":"6.4"}]' | |||
| opendatahub.io/notebook-python-dependencies: '[{"name":"JupyterLab","version":"3.2"},{"name":"Notebook","version":"6.4"}]' | |||
| openshift.io/imported-from: quay.io/modh/odh-minimal-notebook-container | |||
There was a problem hiding this comment.
Could you change also the field openshift.io/imported-from to -> openshift.io/imported-from: quay.io/modh/cuda-notebooks ?
There was a problem hiding this comment.
Overall, the change in the JupyterLab version looks good to me
There was a problem hiding this comment.
@lucferbux could you review the PR as well? I don't have permission to merge it
update `openshift.io/imported-from` field
|
I cannot merge this, needs owner permissions from github's own repository. Maybe @anishasthana can help. |
|
I can merge this, but I'd like confirmation on if this needs to go upstream too first. |
|
Right, it also needs to be updated on the upstream repo too. Here is the PR that pushes the same changes cc @lucferbux, @anishasthana |
Remove the .z stream from the JupyterLab dependency, since it is not shown for any other library in any of the images
[UPSTREAM]has been prepended to the commit message