Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update csv annotation #195

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Update csv annotation #195

merged 2 commits into from
Jun 1, 2022

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented May 17, 2022 •
edited
Loading

Added annotations for containerImage, description,
operatorframework.io/cluster-monitoring: "true",
operatorframework.io/initialization-resource, repository and support in
the CSV

Screenshot from 2022-05-17 20-26-42
Screenshot from 2022-05-17 20-26-23
Screenshot from 2022-05-17 20-26-13
Screenshot from 2022-05-17 20-24-42
Screenshot from 2022-05-17 20-24-27

@sp98 sp98 requested a review from nbalacha May 17, 2022 14:58
sp98 added 2 commits May 30, 2022 18:53
@sp98
fix: update csv annotations
2192466 
Added annotations for containerImage, description,
operatorframework.io/cluster-monitoring: "true",
operatorframework.io/initialization-resource, repository and support in
the CSV

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
@sp98
build: run make bundle
8aaa288 
Signed-off-by: Santosh Pillai <sapillai@redhat.com>
@sp98 sp98 force-pushed the update-csv-annotation branch from 5e6d029 to 8aaa288 Compare May 30, 2022 13:23
@sp98 sp98 requested a review from nbalacha May 30, 2022 16:10
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@sp98: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index-lvm-operator-static-deps 8aaa288 link unknown /test ci-index-lvm-operator-static-deps
ci/prow/images 8aaa288 link unknown /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nbalacha nbalacha merged commit c7d35ae into openshift:main Jun 1, 2022
@sp98 sp98 mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbalacha nbalacha nbalacha approved these changes

Assignees

@nbalacha nbalacha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sp98 @nbalacha