-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controllers: send the client profile mapping required for DR #2879
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rewantsoni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
350e6bf
to
fbc1c87
Compare
) | ||
|
||
const ( | ||
monConfigMap = "rook-ceph-mon-endpoints" | ||
monSecret = "rook-ceph-mon" | ||
) | ||
|
||
const peerPoolIDConfigMapName = "peer-pool-id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving this above after line 60.
@@ -16,6 +16,7 @@ rules: | |||
resources: | |||
- cephfilesystemsubvolumegroups | |||
- cephblockpoolradosnamespaces | |||
- cephblockpools | |||
verbs: | |||
- get | |||
- list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Ceph block pool, you only need to get access. I am not sure Is it fair to add a new entry for the same API group?
fbc1c87
to
45e6d61
Compare
this mapping is sent only if rns is enabled for mirroring remote poolID is fetched from GetBlockPoolInfo rpc, which is then written to a configMap to be read in provider server local poolID is fetched from cephBlockPool status Signed-off-by: Rewant Soni <resoni@redhat.com>
45e6d61
to
a84e6fb
Compare
This mapping is sent only if rns is enabled for mirroring