controllers: create odf-deps sub while starting manager

creating odf-deps subscription while starting manager will speed up the
process.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>

controllers/subscription_controller.go

@@ -32,6 +32,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/event"
 	"sigs.k8s.io/controller-runtime/pkg/handler"
 	"sigs.k8s.io/controller-runtime/pkg/log"
+	"sigs.k8s.io/controller-runtime/pkg/manager"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 
@@ -290,6 +291,14 @@ func (r *SubscriptionReconciler) SetupWithManager(mgr ctrl.Manager) error {
 		},
 	)
 
+	err := mgr.Add(manager.RunnableFunc(func(ctx context.Context) error {
+		odfDepsSub := GetStorageClusterSubscriptions()[0]
+		return EnsureDesiredSubscription(r.Client, odfDepsSub)
+	}))
+	if err != nil {
+		return err
+	}
+
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&operatorv1alpha1.Subscription{},
 			builder.WithPredicates(generationChangedPredicate, subscriptionPredicate)).

controllers/subscriptions.go

@@ -618,6 +618,8 @@ func GetStorageClusterSubscriptions() []*operatorv1alpha1.Subscription {
 		},
 	}
 
+	// Do not change the inxex of odfDepsSubscription. The 0 index is being used to create this subscription
+	// while starting in the subscription controller in SetupWithManager.
 	return []*operatorv1alpha1.Subscription{odfDepsSubscription, ocsSubscription, rookSubscription, noobaaSubscription,
 		csiAddonsSubscription, cephCsiSubscription, ocsClientSubscription, prometheusSubscription, recipeSubscription}
 }

controllers/subscriptions_test.go

@@ -30,6 +30,13 @@ import (
 	odfv1alpha1 "github.com/red-hat-storage/odf-operator/api/v1alpha1"
 )
 
+func TestSubscriptionIndex(t *testing.T) {
+	odfDepsSub := GetStorageClusterSubscriptions()[0]
+	msg := "odfDepsSub variable is expected to contain the 'odf-dependencies' subscription. " +
+		"Ensure the 'odf-dependencies' subscription indexed at 0."
+	assert.Equal(t, OdfDepsSubscriptionPackage, odfDepsSub.Spec.Package, msg)
+}
+
 func TestEnsureSubscription(t *testing.T) {
 
 	testCases := []struct {