Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation for STS support #344

Merged

Conversation

Nikhil-Ladha
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha commented Nov 20, 2023

Added an annotation to odf-operator CSV for STS support.

Ref: https://issues.redhat.com/browse/RHSTOR-5097

@Nikhil-Ladha Nikhil-Ladha force-pushed the annotation-for-aws-sts branch 3 times, most recently from 7322fdd to a620219 Compare November 20, 2023 09:26
Added an annotation to odf-operator CSV for STS support.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@Nikhil-Ladha Nikhil-Ladha force-pushed the annotation-for-aws-sts branch from a620219 to 2f93073 Compare November 20, 2023 09:28
@Nikhil-Ladha
Copy link
Member Author

@iamniting updated the PR to only add a new annotation to the CSV

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@iamniting
Copy link
Member

/override ci/prow/odf-operator-e2e-aws

Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/odf-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b0b53fc into red-hat-storage:main Nov 20, 2023
17 checks passed
@Nikhil-Ladha Nikhil-Ladha deleted the annotation-for-aws-sts branch June 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants