Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2255315:[release-4.14] Surface dependent Operator upgradeable conditions #359

Closed
wants to merge 3 commits into from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 20, 2023

manual cherry-pick of #355, the difference is updating go.mod with only required modules

Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@leelavg: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Surface dependent Operator upgradeable conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg
Once this PR has been reviewed and has the lgtm label, please assign obnoxxx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg leelavg changed the title Surface dependent Operator upgradeable conditions Bug 2244567:[release-4.14] Surface dependent Operator upgradeable conditions Dec 20, 2023
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@leelavg: This pull request references Bugzilla bug 2244567, which is invalid:

  • expected the bug to target the "ODF 4.14.4" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2244567:[release-4.14] Surface dependent Operator upgradeable conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
- odf-operator brings dependencies using OLM
- this PR ensures odf-operator sets it's own operator condition based on
upgradeability of it's dependents.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
@iamniting iamniting changed the title Bug 2244567:[release-4.14] Surface dependent Operator upgradeable conditions Bug 2255315:[release-4.14] Surface dependent Operator upgradeable conditions Dec 20, 2023
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@leelavg: This pull request references Bugzilla bug 2255315, which is invalid:

  • expected the bug to target the "ODF 4.14.4" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2255315:[release-4.14] Surface dependent Operator upgradeable conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@leelavg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-operator-e2e-aws 2a798c2 link true /test odf-operator-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leelavg
Copy link
Contributor Author

leelavg commented Feb 8, 2024

taken in #369

@leelavg leelavg closed this Feb 8, 2024
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

@leelavg: An error was encountered removing this pull request from the external tracker bugs for bug 2255315 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2255315:[release-4.14] Surface dependent Operator upgradeable conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant