Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: Fixes update issue in ConsolePlugin #365

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

bipuladh
Copy link
Contributor

ConsolePlugin gets correctly updated in upgrade scenarios

Fixes Bug 2258015

Makefile Outdated
@@ -105,7 +105,7 @@ run: manifests generate fmt vet ## Run a controller from your host.
go run ./main.go

docker-build: godeps-update test-setup ## Build docker image with the manager.
docker build -t ${IMG} .
podman build -t ${IMG} .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. this shouldn't have been part of the PR. changing.

ConsolePlugin gets correctly updated in upgrade scenarios

Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@bipuladh
Copy link
Contributor Author

/cherrypick release-4.15

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/override ci/prow/odf-operator-e2e-aws

Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/odf-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/cherrypick fusion-hci-4.14

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of fusion-hci-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick fusion-hci-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c773281 into red-hat-storage:main Jan 22, 2024
16 checks passed
@openshift-cherrypick-robot

@bipuladh: new pull request created: #366

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bipuladh: new pull request created: #367

In response to this:

/cherrypick fusion-hci-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants