-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: Fixes update issue in ConsolePlugin #365
console: Fixes update issue in ConsolePlugin #365
Conversation
Makefile
Outdated
@@ -105,7 +105,7 @@ run: manifests generate fmt vet ## Run a controller from your host. | |||
go run ./main.go | |||
|
|||
docker-build: godeps-update test-setup ## Build docker image with the manager. | |||
docker build -t ${IMG} . | |||
podman build -t ${IMG} . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. this shouldn't have been part of the PR. changing.
ConsolePlugin gets correctly updated in upgrade scenarios Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
7d29127
to
921c315
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-4.15 |
@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/odf-operator-e2e-aws |
@iamniting: Overrode contexts on behalf of iamniting: ci/prow/odf-operator-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick fusion-hci-4.14 |
@bipuladh: once the present PR merges, I will cherry-pick it on top of fusion-hci-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c773281
into
red-hat-storage:main
@bipuladh: new pull request created: #366 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bipuladh: new pull request created: #367 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ConsolePlugin gets correctly updated in upgrade scenarios
Fixes Bug 2258015