check CSV phase to be succeeded for container readiness #506
Conversation
Signed-off-by: Nitin Goyal <nigoyal@redhat.com> (cherry picked from commit 87ac048)
|
This PR/issue depends on:
|
leelavg
force-pushed
the
readiness-probe
branch
3 times, most recently
from
7adfdf3 to
0ba41f3
Compare
main.go
Outdated
| // console plugin is dependent on CRDs that are part of these CSVs and we | ||
| // can't check for only odf-dependencies CSV as OLM doesn't guarantee | ||
| // (based on observations) existence of all CRDs brought by OLM dependency | ||
| // mechanism. |
There was a problem hiding this comment.
| // console plugin is dependent on CRDs that are part of these CSVs and we | |
| // can't check for only odf-dependencies CSV as OLM doesn't guarantee | |
| // (based on observations) existence of all CRDs brought by OLM dependency | |
| // mechanism. | |
| // The console plugin depends on CRDs provided by these CSVs. | |
| // Checking only the odf-dependencies CSV is insufficient, | |
| // because, based on observations, the presence of all required CRDs | |
| // is not guaranteed even when the odf-dependencies CSV is in a succeeded state. |
pkg/util/readiness.go
Outdated
| } | ||
| if len(csvMap) != 0 { | ||
| for csvName := range csvMap { | ||
| return fmt.Errorf("CSV %s is not found", csvName) |
There was a problem hiding this comment.
It will just return only first one. The loop will only run once.
There was a problem hiding this comment.
that'll still be fine, isn't it? we just aren't ready.
There was a problem hiding this comment.
What i mean to say here is we can just return the first item if the list is not empty, we don't need a loop.
leelavg
force-pushed
the
readiness-probe
branch
from
0ba41f3 to
e95a876
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leelavg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I am adding the screenshot of the observation here for future reference that just checking the odf-dependencies csv is not enough.
|
leelavg
force-pushed
the
readiness-probe
branch
3 times, most recently
from
295224e to
27da06f
Compare
odf-operator creates subscription for odf-dependencies and CRDs will become available once respective CSVs are present in the cluster. We check the phase of respective CSVs which are required for odf-op before becoming ready. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
90s for timeout is choosen based on a couple of observations that it took around a minute for InstallPlan to be realised as CSVs on the cluster. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
|
@leelavg: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
These commits are merged as part of #499. I am closing this. |
odf-operator creates subscription for odf-dependencies and CRDs will become available once respective CSVs are present in the cluster. We check the phase of respective CSVs which are required for odf-op before becoming ready.
Depends on #503