Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add few tweaks #512

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add few tweaks #512

merged 3 commits into from
Nov 21, 2024

Conversation

iamniting
Copy link
Member

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@iamniting
bundle: Add imagePullPolicy to Always
72d2f8a 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@iamniting
Copy link
Member Author

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws
/override ci/prow/images

@iamniting
godeps: add vendor changes
18b3413 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
action: add verification for generated changes in root
87b3943 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ci-bundle-odf-operator-bundle, ci/prow/images, ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Nikhil-Ladha
Nikhil-Ladha approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws
/override ci/prow/images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ci-bundle-odf-operator-bundle, ci/prow/images, ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7897655 into red-hat-storage:main Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikhil-Ladha Nikhil-Ladha Nikhil-Ladha approved these changes

Assignees

@Nikhil-Ladha Nikhil-Ladha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamniting @Nikhil-Ladha