-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translations #272
Add translations #272
Conversation
Hey, thank you so much for implementing this! We really appreciate it. It looks good except for the holes being in a broken state and their indicator being present because our check for them is really primitive. I will review it in the following days :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Pull Request looks great apart from a few minor issues and you can merge it once those are fixed:
- The English IntroScreen has Text that overruns to the right
- Some Internal Code sadly depends on the names of the Machines(due to time constraints in the project). So in event.rs Line 164 and in generate_machines.rs Line 34 we use kanguage-dependent variables so changing the language changes the behaviour.
Again thank you for taking the time to implement this
Preallocated hash map to prevent rehashing. Remove allocations for performance Clippy fixes.
Hi, I think I solved all issues here but unfortunately this ends up being huge PR Here is what I did:
Note: Some inline attributes where removed. Be careful with them and note they are not c++ inline, they are only useful in libraries since they are instruction for compiler this part should be inline in user application not in current library |
Ah so inlining is only useful for usage across crate boundaries. Thanks for pointing that out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, I can't merge or sign reviewer. Additionally I created couple issues |
No description provided.