Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Pull over deploy script changes from react.london #32

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Pull over deploy script changes from react.london #32

merged 1 commit into from
Jul 8, 2016

Conversation

lpil
Copy link
Contributor

@lpil lpil commented Jul 5, 2016

planefail

@asavin
Copy link
Contributor

asavin commented Jul 7, 2016

@lpil maybe couple of words on motivation of this PR?

@lpil
Copy link
Contributor Author

lpil commented Jul 8, 2016 •
edited
Loading

Sure. Spoke with Chris but should have left notes. I'll annotate the changes.

lpil
lpil reviewed Jul 8, 2016
View reviewed changes
bin/deploy.sh
fi

set -eu
set -o pipefail
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safer bash options. Set after the variable checking as otherwise we get an ugly error message when the user forgets to pass the argument rather than the friendlier one above.

@asavin asavin merged commit 18206c0 into master Jul 8, 2016
@asavin asavin deleted the deploy branch July 8, 2016 10:50
@lpil
Copy link
Contributor Author

lpil commented Jul 8, 2016

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpil @asavin