Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Added featuredEvent property to community type #41

Merged
merged 2 commits into from
Jul 19, 2016
Merged

Added featuredEvent property to community type #41

merged 2 commits into from
Jul 19, 2016

Conversation

AndrewBestbier
Copy link
Contributor

@AndrewBestbier AndrewBestbier commented Jul 19, 2016 •
edited
Loading

Pre-flight checklist

  • Unit tests
  • GraphiQL tested
  • Client app tested
  • Gif added

Alt Text

lpil
lpil reviewed Jul 19, 2016
View reviewed changes
lib/community/communityFields.js
description: 'The community\'s featured event',
resolve(community) {
if (community) {
const id = pathOr('', ['document', 'id'], community.featuredEvent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default to empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or null?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense to me.

@AndrewBestbier AndrewBestbier merged commit a986cfa into master Jul 19, 2016
@asavin asavin deleted the adding-featured-event branch September 5, 2016 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewBestbier @lpil