This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Added address field to event type #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is address descriptive enough? Also needs a location link which will be used for a google maps link on react.london events |
|
@lpil Do you need co-ords? I know in prismic we store both the event address and event co-ords. I should probably make it query able for the Api anyway. |
|
Coordinates will be super useful when implement things like OpenGraph and Schema Org |
|
Yes please, we need them on React London for the google maps link Can built it like so: http://www.google.com/maps/place/49.46800006494457,17.11514008755796 |
| @@ -76,6 +77,10 @@ export const EventType = new GraphQLObjectType({ | |||
| type: GraphQLString, | |||
| description: 'Filename of an image uploaded to a 3rd party hosting service', | |||
| }, | |||
| location: { | |||
| type: LocationType, | |||
| description: 'The address of the event in both postal and coordinate form', | |||
There was a problem hiding this comment.
Yup. I have broken it further down now so it is now:
location -> address, coordinates -> lat, long
|
Looks good :) |
AndrewBestbier
force-pushed
the
adding-address-to-event-type
branch
from
925925b to
94aa626
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.