Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Added waitingListOpen boolean to event type #52

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

AndrewBestbier
Copy link
Contributor

@AndrewBestbier AndrewBestbier commented Jul 28, 2016

Motivation

After a discussion with Amy, Tania and Sammy it was decided that a new 'switch' will be needed on the prismic site to enable the entire ticket release process. This boolean is 'waitingListOpen'.

The current process is then:

Step 1

  • Amy adds Event Start Time
  • Amy adds Event End Time
  • Amy adds Ticket Release Time
  • Amy sets tickets available to False.
  • Amy sets the event link to an empty string.
  • Amy sets the streaming link to an empty string.
  • Amy sets waiting list open to False.
  • The current time is before the Ticket Release Time.

screen shot 2016-07-28 at 16 17 41

Step 2

  • Amy sets tickets available to True.
  • Amy sets the event link to the relevant site (EventBrite/Facebook etc).
  • The current time is after the Ticket Release Time.

screen shot 2016-07-28 at 16 20 09

Step 3

  • Amy sets tickets available to False.
  • Amy sets waiting list open to True

screen shot 2016-07-28 at 16 20 54

Step 4

  • Amy sets waiting list open to False

screen shot 2016-07-28 at 16 23 44

Step 5

  • Amy sets the streaming link to the relevant youtube link

screen shot 2016-07-28 at 16 25 11

Step 6

  • The current time is after the event end time

screen shot 2016-07-28 at 16 25 39

Thoughts

This may be relatively tricky to program bearing in mind that Prismic does not allow us to have mandatory fields. Another suggestion would be to edit all the fields manually.

For example, in Prismic, the user could edit the button text, button link, event status title etc. However, this would result in a process that requires much more manual work.

@asavin
Copy link
Contributor

asavin commented Jul 28, 2016

I suppose this is when we could implement the validation layer in Badger Brain, as proposed in #43

It doesn't look easy, but considering that we only have 1 admin user, should be alright. Basically - set values into fields, check on live site.

@asavin asavin merged commit fa674a0 into master Jul 28, 2016
@asavin asavin deleted the adding-waiting-list-open branch July 28, 2016 15:48
@lpil
Copy link
Contributor

lpil commented Jul 28, 2016

Wouldn't it make more sense to have a 3 value enumeration over a boolean? This section has multiple states- it's hard to represent this with boolean values, and results in awkward and complex logic trees like the one detailed in the post.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants