Replaced BOOST_ASSERT with overwrite.

It is corner case but BOOST_ASSERT is too strong. Overwrite is better solution.
redboltz · May 7, 2019 · e54f2e4 · e54f2e4
1 parent a29da19
commit e54f2e4
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/include/mqtt/endpoint.hpp b/include/mqtt/endpoint.hpp
@@ -10172,7 +10172,24 @@ class endpoint : public std::enable_shared_from_this<endpoint<Socket, Mutex, Loc
                         control_packet_type::pubcomp,
                         msg
                     );
-                    BOOST_ASSERT(ret.second);
+                    // publish store is erased when pubrec is received.
+                    // pubrel store is erased when pubcomp is received.
+                    // If invalid client send pubrec twice with the same packet id,
+                    // then send corresponding pubrel twice is a possible client/server
+                    // implementation.
+                    // In this case, overwrite store_.
+                    if (!ret.second) {
+                        store_.modify(
+                            ret.first,
+                            [&] (auto& e) {
+                                e = store(
+                                    packet_id,
+                                    control_packet_type::pubcomp,
+                                    msg
+                                );
+                            }
+                        );
+                    }
                 }
 
                 if (serialize) {