Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt build fails since resolution of #399 #424

Closed
ropieur opened this issue Sep 12, 2019 · 2 comments
Closed

mqtt build fails since resolution of #399 #424

ropieur opened this issue Sep 12, 2019 · 2 comments

Comments

@ropieur
Copy link

ropieur commented Sep 12, 2019

cmake ends up with the following error

CMake Error at include/CMakeLists.txt:56 (string):
string sub-command REPLACE requires at least four arguments.

Might be $ENV{CXXFLAGS} is empty?

@ropieur
Copy link
Author

ropieur commented Sep 12, 2019

I confirm that the fix works for me.
Shouldn't you consider the same kind of fix for the previous line in CMakeLists.txt?

@redboltz
Copy link
Owner

Thanks. At first, I thought that CMAKE_CXX_FLAGS is set at root of CMakeLists.txt. But I found the path that CMAKE_CXX_FLAGS isn't set. So I updated the PR.

redboltz added a commit that referenced this issue Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants