Resolves #222 #230
Merged
Resolves #222 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redboltz
added a commit
that referenced
this pull request
May 17, 2019
More minor tweaks pertaining to #230
|
I have not forgotten about this. I'm just very busy recently. |
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=========================================
- Coverage 84.92% 84.9% -0.03%
=========================================
Files 33 33
Lines 4862 4855 -7
=========================================
- Hits 4129 4122 -7
Misses 733 733 |
redboltz
reviewed
Jun 18, 2019
test/as_buffer_async_pubsub_1.cpp
Outdated
| as::buffer(*contents), | ||
| false, | ||
| [topic1, contents](boost::system::error_code const&) {} | ||
| as::buffer("topic1"), |
There was a problem hiding this comment.
I don't want to add '\0' after the string. Please use https://github.com/redboltz/mqtt_cpp/pull/286/files#diff-c039c862d67b802e139cb035c26dcc4dR235 way.
There was a problem hiding this comment.
And please do the same update other places on the test.
|
This code is now ready for review and merge. |
|
LGTM, thank you! |
redboltz
added a commit
that referenced
this pull request
Oct 3, 2019
Remain the deferred event that from deferred_queue during the transition process. Then, process the next deferred event. The event position is not front(), so `std::queue` concept doesn't satisfies it. I need iteration concept something like `std::deque`. In order to do that, I introduced two flags that are `defer_processing_` and `defer_again_`. In addition, to iterate deferred deque, two iterators `defer_it_` and `defer_end_` are introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.