Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #186, #191 #231

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Resolves #186, #191 #231

merged 1 commit into from
Jul 2, 2019

Conversation

jonesmz
Copy link
Contributor

@jonesmz jonesmz commented Apr 26, 2019

No description provided.

@jonesmz
Copy link
Contributor Author

jonesmz commented Jun 5, 2019

I have not forgotten about this. I'm just very busy recently.

@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #231 into master will decrease coverage by 4.3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   85.49%   81.18%   -4.31%     
==========================================
  Files          34       32       -2     
  Lines        4880     4459     -421     
==========================================
- Hits         4172     3620     -552     
- Misses        708      839     +131

@redboltz
Copy link
Owner

redboltz commented Jul 2, 2019

Thank you for updating.

@redboltz redboltz closed this Jul 2, 2019
@redboltz redboltz reopened this Jul 2, 2019
@redboltz redboltz merged commit 3fa61e9 into redboltz:master Jul 2, 2019
@jonesmz jonesmz deleted the string_view branch July 3, 2019 00:18
@jonesmz jonesmz restored the string_view branch July 3, 2019 00:19
@jonesmz jonesmz deleted the string_view branch July 3, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants