Minor improvements to template function handling. Preliminary for the work in PR#230 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesmz
commented
Apr 26, 2019
| @@ -9491,47 +9491,6 @@ class endpoint : public std::enable_shared_from_this<endpoint<Socket, Mutex, Loc | |||
| } | |||
| } | |||
|
|
|||
| void send_publish_no_lifetime( | |||
There was a problem hiding this comment.
Sorry to put this in and then take it out, but after considering it more, I don't think that this function needs to have two different versions. The second version essentially only saved a single conditional, after the optimizer finished with it.
jonesmz
commented
Apr 26, 2019
| std::vector<std::uint8_t> params; | ||
| async_send_unsuback(std::move(params), packet_id, qos, std::forward<Args>(args)..., async_handler_t()); | ||
| Args&&... qos) { | ||
| async_send_unsuback(std::vector<std::uint8_t>({qos...}), packet_id, async_handler_t()); |
There was a problem hiding this comment.
Do parameter pack expansion to create the vector directly. No need for recursion.
|
Thank you! |
redboltz
pushed a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.