Added exception handling code. #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing `acceptor_.reset()`.
jonesmz
reviewed
May 13, 2019
include/mqtt/server.hpp
Outdated
| @@ -84,9 +84,25 @@ class server { | |||
| void listen() { | |||
| close_request_ = false; | |||
| renew_socket(); | |||
|
|
|||
| auto post_error = | |||
| [&](boost::system::error_code const& ec) { | |||
There was a problem hiding this comment.
Why the lambda? It's only used in one place (inside the try-catch).
It would be simpler to call ios_accept_.post() directly, wouldn't it?
There was a problem hiding this comment.
@jonesmz I will fix it as you pointed out.
I tried open, set_option, bind, listen, and then accept approach before, but didn't work as I expected. The lambda was used multiple times at that approach. I forgot to update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing
acceptor_.reset().