Fix 298 #299
Merged
Fix 298 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the member variable `std::unique_ptr<socket_t> socket_` from servers and added the local variable `std::shared_ptr<socket_t> socket`. Removed invalid error handler call. Error handler is called when TCP accept is failed. If the next accepting process is successfully started, but individual socket processing is failed case, error handler shouldn't be called. (Maybe should be logged when logging mechanism is introduced.)
This doesn't mean immediate release.
jonesmz
reviewed
Jun 25, 2019
| socket_->lowest_layer(), | ||
| [this] | ||
| socket->lowest_layer(), | ||
| [this, socket] |
There was a problem hiding this comment.
Ah. Never mind. Parameter evaluation order problem.
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
========================================
+ Coverage 84.92% 85% +0.08%
========================================
Files 33 33
Lines 4862 4848 -14
========================================
- Hits 4129 4121 -8
+ Misses 733 727 -6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.