Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error code. #658

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fixed error code. #658

merged 2 commits into from
Sep 8, 2020

Conversation

redboltz
Copy link
Owner

@redboltz redboltz commented Sep 8, 2020

Invalid length on MQTT protocol was boost::system::errc::message_size.
But it was not appropriate.
See
#650 (comment)

These errors are replaced with boost::system::errc::protocol_error
because it is MQTT protocol violation.

Unexpected boost asio transferred_size error was also mapped
boost::system::errc::message_size.

It is replaced with boost::system::errc::bad_message.

Invalid length on MQTT protocol was `boost::system::errc::message_size`.
But it was not appropriate.
See
#650 (comment)

These errors are replaced with `boost::system::errc::protocol_error`
because it is MQTT protocol violation.

Unexpected boost asio transferred_size error was also mapped
`boost::system::errc::message_size`.

It is replaced with `boost::system::errc::bad_message`.
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #658 into master will increase coverage by 0.02%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   82.14%   82.17%   +0.02%     
==========================================
  Files          45       45              
  Lines        7006     7006              
==========================================
+ Hits         5755     5757       +2     
+ Misses       1251     1249       -2     

@redboltz redboltz merged commit 99a5426 into master Sep 8, 2020
@redboltz redboltz deleted the fix_error_code branch September 8, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant