Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and bugfixes for subscription map and retained map #689

Merged
merged 2 commits into from
Oct 17, 2020

Conversation

kleunen
Copy link
Contributor

@kleunen kleunen commented Oct 17, 2020

No description provided.

Copy link
Owner

@redboltz redboltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the review comments. Please check them.

test/subscription_map.cpp Outdated Show resolved Hide resolved
test/subscription_map.hpp Outdated Show resolved Hide resolved
test/subscription_map.cpp Outdated Show resolved Hide resolved
test/subscription_map.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #689 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #689   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files          47       47           
  Lines        7100     7100           
=======================================
  Hits         5839     5839           
  Misses       1261     1261           

@redboltz redboltz merged commit 646ead2 into redboltz:master Oct 17, 2020
@redboltz
Copy link
Owner

Merged. I added two more commits.
See https://github.com/redboltz/mqtt_cpp/commits/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants