Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and cleanup retained map test #742

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Fix and cleanup retained map test #742

merged 2 commits into from
Nov 30, 2020

Conversation

kleunen
Copy link
Contributor

@kleunen kleunen commented Nov 28, 2020

No description provided.

@kleunen kleunen mentioned this pull request Nov 28, 2020
Closed
@codecov
Copy link

codecov bot commented Nov 28, 2020 •
edited
Loading

Codecov Report

Merging #742 (420714f) into master (2627573) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          46       46           
  Lines        7031     7031           
=======================================
  Hits         5957     5957           
  Misses       1074     1074

redboltz
redboltz reviewed Nov 29, 2020
View reviewed changes
test/subscription_map.hpp Outdated Show resolved Hide resolved
@redboltz
Copy link
Owner

Thank you. It looks good to me.
I commented about some of minor coding style.

@kleunen @redboltz
Apply suggestions from code review
420714f 
Co-authored-by: Takatoshi Kondo <redboltz@gmail.com>
@redboltz redboltz merged commit 517f6bb into redboltz:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redboltz redboltz redboltz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleunen @redboltz