Raise a SlotNotCoveredError in rediscluster if slot doesnt exist
#833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmir
changed the title
SlotNotCoveredError in rediscluster slot doesnt existSlotNotCoveredError in rediscluster if slot doesnt exist
justinmir
force-pushed
the
redis-cluster-fix
branch
4 times, most recently
from
cc674b6
to
fea09d5
Compare
The redis-py-cluster library does not properly handle a KeyError from `get_node_by_slot`. In their code they convert KeyError's to `SlotNotCoveredError` triggering a topology refresh, we should do the same in our derived class that overrides `get_node_by_slot`. See https://github.com/Grokzen/redis-py-cluster/blob/8a8102a9d758d61a7ec1e2ac9050fcd34029ff3f/rediscluster/connection.py#L378 for how this is implemented in the client library.
justinmir
force-pushed
the
redis-cluster-fix
branch
from
fea09d5
to
771cc61
Compare
chriskuehl
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Fixes a bug that causes
redis-clusterclient to fail to refresh the topology when a failover occurs in the Redis cluster.📜 Details
The redis-py-cluster library does not properly handle a KeyError from
get_node_by_slot. In their code they convert KeyError's toSlotNotCoveredErrortriggering a topology refresh, we should do the same in our derived class that overridesget_node_by_slot.See https://github.com/Grokzen/redis-py-cluster/blob/8a8102a9d758d61a7ec1e2ac9050fcd34029ff3f/rediscluster/connection.py#L378 for how this is implemented in the client library.
🧪 Testing Steps / Validation
Tested baseplate.py client in test pod connected to cluster performing failover.
✅ Checks