Migrate to Poetry

[chriskuehl]

This PR migrates Baseplate to use Poetry for dependency management. Poetry is now responsible for managing Baseplate's dependencies and setting up a local Python environment. The benefits over the previous setup include:

• A local virtualenv which includes linters and other dependencies.
• No more manually resolving version conflicts or doing upgrades; Poetry has a CLI for it.
• No more unpinned requirements being sneakily introduced.
• Poetry solves for all compatible operating systems and Python versions with a single lock file.

Poetry only affects our own development workflow; the files that are published to PyPI are effectively identical. Consumers do not need to switch to Poetry or change anything about their workflow.

Changes in this PR

This PR upgrades many dependencies, but I've held back a few (pytest, black, reorder-python-imports) which require code changes for now.

Keep in mind that these dependency bumps, just like the ones in the old requirements*.txt files, are only used by this repo's own tests. They do not affect consumers or releases we make.

Validation

I generated a wheel on the current develop branch (python setup.py bdist_wheel) and a wheel on this branch using Poetry (poetry build). You can see a diff of the extracted wheel contents here: https://gist.github.com/chriskuehl/207271df9b590c83557d2d046b4f0913

Most of the changes are due to differences in whitespace or sorting between setuptools and Poetry. The only notable change is that I removed the all extra since it's a little harder to support, and it appears to be unused. I don't think there's much use-case for all other than developing on the package itself, and poetry install --all-extras handles that for us.

[chriskuehl]

Notable change: right now, the version is embedded here and not based on SCM tags, so we'll need to manually update this file when making new releases.

We may want to consider adopting https://github.com/mtkennerly/poetry-dynamic-versioning (haven't used it, but looks like what we want)? I'm inclined to wait and do it in a followup PR once we're sure all the other machinery is working.

[mathyourlife-reddit]

NICE!

[mathyourlife-reddit]

With reorder-python-imports 3.12.0, I get

reorder-python-imports: error: unrecognized arguments: --separate-from-import --separate-relative

Removal of those arguments from the Makefile line 1 allows it to run for me.

[chriskuehl]

Hmm, how did you end up with that version of reorder-python-imports? I also ran into that issue initially but I pinned it back down to the version we're using prior to this branch since I was trying to avoid making additional changes:

baseplate.py/pyproject.toml

Line 75 in 81544de

reorder-python-imports = "2.4.0"

Did you install dependencies with Poetry? What does poetry show reorder-python-imports produce?

[mathyourlife-reddit]

Just did a pipx install reorder-python-imports

$ poetry show reorder-python-imports
 name         : reorder-python-imports
 version      : 2.4.0
 description  : Tool for reordering python imports

dependencies
 - aspy.refactor-imports >=2.1.0

[mathyourlife-reddit]

A few references to requirements.txt and runtime.txt remain in the repo. Mostly comments or markdown.

git grep 'runtime.*txt'
git grep 'requirements.*txt'

[mathyourlife-reddit]

I ran into a similar issue to make fmt for make lint

reorder-python-imports: error: unrecognized arguments: --diff-only

[salomon-smekecohen]

I have some nits and some other comments! But overall this is great.

[salomon-smekecohen]

meant to approve last review 😅

[chriskuehl]

@salomon-smekecohen I pushed a new commit addressing some of the main feedback. Let me know if you have thoughts on any of the open threads (or threads I closed)!

[salomon-smekecohen]

king